[ENH] Allow additional columns if defined for various TSV files #2054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remi-Gau
approved these changes
Feb 13, 2025
effigies
commented
Feb 13, 2025
|
@yarikoptic Could I trouble you for a review? I suspect most of our European friends are on holiday, you seem active, and I think this should be straightforward. |
effigies
commented
May 15, 2025
| @@ -21,6 +21,7 @@ Blood: | |||
| whole_blood_radioactivity: | |||
| level: optional | |||
| level_addendum: required if `WholeBloodAvail` is `true` | |||
| additional_columns: allowed_if_defined | |||
There was a problem hiding this comment.
@mnoergaard @melanieganz Can you confirm whether blood.tsv files are permitted to have unknown columns? The options are allowed (warn if undefined by BIDS spec or sidecar), allowed_if_defined (error if undefined by BIDS spec or sidecar), and not_allowed (error if undefined by BIDS spec).
effigies
force-pushed
the
fix/segmentation-tsv
branch
from
42bb79a to
1125fd2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2054 +/- ##
=======================================
Coverage 82.06% 82.06%
=======================================
Files 17 17
Lines 1533 1533
=======================================
Hits 1258 1258
Misses 275 275 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
effigies
force-pushed
the
fix/segmentation-tsv
branch
from
1125fd2 to
19cf2f4
Compare
rwblair
approved these changes
May 22, 2025
effigies
added a commit
that referenced
this pull request
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several table definitions were missing an indication of whether additional columns were allowed, which defaults to
not_allowed. This PR updates the metaschema to require the field to be explicit, and sets its value toallowed_if_definedfor all cases that were missing.cc @melanieganz @CPernet @mnoergaard for your thoughts on the PET cases. This is strictly speaking a relaxation, but IMO if people provide definitions, that's good?
Closes #1993.